diff --git a/src/engine/media/MT_Statistics.cpp b/src/engine/media/MT_Statistics.cpp index 5596ceba..0d9a8307 100644 --- a/src/engine/media/MT_Statistics.cpp +++ b/src/engine/media/MT_Statistics.cpp @@ -40,9 +40,9 @@ void JitterStatistics::process(jrtplib::RTPPacket* packet, int rate) int64_t delta = receiveDelta - timestampDelta; // Update max delta in milliseconds - double delta_in_ms = fabs(double(delta) / (rate / 1000)); - if (delta_in_ms > mMaxDelta) - mMaxDelta = delta_in_ms; + double delta_in_seconds = fabs(double(delta) / rate); + if (delta_in_seconds > mMaxDelta) + mMaxDelta = delta_in_seconds; // Update jitter value in units mLastJitter = mLastJitter.value() + (fabs(double(delta)) - mLastJitter.value()) / 16.0; @@ -55,6 +55,7 @@ void JitterStatistics::process(jrtplib::RTPPacket* packet, int rate) mReceiveTime = receiveTime; mReceiveTimestamp = timestamp; + // And mJitter are in seconds again mJitter.process(mLastJitter.value() / rate); } } @@ -201,7 +202,7 @@ double Statistics::calculateMos(double maximalMos) const if (mReceivedRtp < 100) return 0.0; - if (lossr == 0 || burstr == 0) + if (lossr == 0.0 || burstr == 0.0) { return maximalMos; } diff --git a/src/engine/media/MT_Statistics.h b/src/engine/media/MT_Statistics.h index 5cd33b43..4dc3b484 100644 --- a/src/engine/media/MT_Statistics.h +++ b/src/engine/media/MT_Statistics.h @@ -92,10 +92,10 @@ protected: // It is classic jitter value in units optional mLastJitter; - // Some statistics for jitter value in milliseconds + // Some statistics for jitter value in seconds ProbeStats mJitter; - // Maximal delta in milliseconds + // Maximal delta in seconds double mMaxDelta = 0.0; };